Skip to content

bump api versions#28

Open
AEnterprise wants to merge 6 commits into
BuildCraft:8.0.x-1.12.2from
AEnterprise:apiupdate
Open

bump api versions#28
AEnterprise wants to merge 6 commits into
BuildCraft:8.0.x-1.12.2from
AEnterprise:apiupdate

Conversation

@AEnterprise

Copy link
Copy Markdown
Member

between 7.99.4 and 7.99.5 there where api changes but the versions never got bumped

also not sure if the 'owner' of an api can be another api, i beleive this should be a mod as all apis are loaded at the same time so they don't exist yet

@AlexIIL

AlexIIL commented Jul 7, 2017

Copy link
Copy Markdown
Member

This won't be happening until we get out of alpha

@AlexIIL AlexIIL closed this Jul 7, 2017
@AlexIIL AlexIIL reopened this Jul 7, 2017
@AlexIIL

AlexIIL commented Jul 7, 2017

Copy link
Copy Markdown
Member

Is this defiantly everything that's changed since 7.2.x?

@AlexIIL

AlexIIL commented Jul 7, 2017

Copy link
Copy Markdown
Member

Oh right sorry, this only bumps things from 7.99.4 - we really need to bump everything that's changed since 7.2.x, or even 7.1.x.

@AlexIIL AlexIIL closed this Aug 18, 2019
@AlexIIL

AlexIIL commented Aug 18, 2019

Copy link
Copy Markdown
Member

Dammit there's no "re-target button here to retarget to 8.0.x-1.12.2 :/

@AlexIIL

AlexIIL commented Aug 18, 2019

Copy link
Copy Markdown
Member

(Although at this point I think I might have missed the window for changing API versions? I should really have merged this immediately as nothing else will change now in 1.12.2)

@AEnterprise

Copy link
Copy Markdown
Member Author

@AlexIIL you can retarget with the edit button at the next to the name normally

@AlexIIL

AlexIIL commented Aug 18, 2019

Copy link
Copy Markdown
Member

Github only seems to let me edit the target branch if the PR is still open, so I'll re-create the old branch temporarily.

@AlexIIL AlexIIL reopened this Aug 18, 2019
@AlexIIL AlexIIL changed the base branch from 8.0.x to 8.0.x-1.12.2 August 18, 2019 16:42
@AlexIIL

AlexIIL commented Aug 18, 2019

Copy link
Copy Markdown
Member

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants